Skip to content

{containerapp} support connected env command group #6696

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
zhoxing-ms merged 15 commits into from
Sep 5, 2023
Merged

{containerapp} support connected env command group #6696

zhoxing-ms merged 15 commits into from
Sep 5, 2023

Conversation

@Greedygre
Copy link
Contributor

@Greedygre Greedygre commented Aug 29, 2023 •
edited
Loading

This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

az containerapp connected-env show/list/delete/create

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally?

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

@azure-client-tools-bot-prd
Copy link

azure-client-tools-bot-prd bot commented Aug 29, 2023 •
edited
Loading

⚠️Azure CLI Extensions Breaking Change Test
⚠️containerapp
rule cmd_name rule_message suggest_message
⚠️ 1011 - SubgroupAdd containerapp connected-env sub group containerapp connected-env added

@azure-client-tools-bot-prd
Copy link

azure-client-tools-bot-prd bot commented Aug 29, 2023

Hi @Greedygre,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

@azure-client-tools-bot-prd
Copy link

azure-client-tools-bot-prd bot commented Aug 29, 2023

Hi @Greedygre,
Since the current milestone time is less than 7 days, this pr will be reviewed in the next milestone.

@yonzhan
Copy link
Collaborator

yonzhan commented Aug 29, 2023

containerapp

@microsoft-github-policy-service microsoft-github-policy-service bot added the Auto-Assign Auto assign by bot label Aug 29, 2023
@Greedygre Greedygre marked this pull request as draft August 29, 2023 05:46
@Greedygre Greedygre force-pushed the xinyu/support_connected_env_command_group2 branch from c1a211d to f9ce817 Compare August 30, 2023 03:05
@Greedygre Greedygre marked this pull request as ready for review August 30, 2023 04:43
LaylaLiu-gmail
LaylaLiu-gmail reviewed Aug 30, 2023
View reviewed changes
Juliehzl
Juliehzl reviewed Aug 30, 2023
View reviewed changes
Juliehzl
Juliehzl reviewed Aug 30, 2023
View reviewed changes
Juliehzl
Juliehzl reviewed Aug 30, 2023
View reviewed changes
Juliehzl
Juliehzl reviewed Aug 30, 2023
View reviewed changes
Juliehzl
Juliehzl reviewed Aug 30, 2023
View reviewed changes
@Greedygre
Copy link
Contributor Author

Greedygre commented Aug 30, 2023

Hi @zhoxing-ms @wangzelin007
The (Verify Ref Docs) failed, could you help to handle? Thanks.

@zhoxing-ms
Copy link
Contributor

zhoxing-ms commented Aug 31, 2023

The (Verify Ref Docs) failed, could you help to handle? Thanks

Known issue, we have made the Verify Ref Docs as continueOnError, so it won't block our merge this PR

@Greedygre
Copy link
Contributor Author

Greedygre commented Aug 31, 2023 •
edited
Loading

Hi @zhoxing-ms @yonzhan
This PR has been review by zunli, could you help to review and merge this PR?
Thanks.

zhoxing-ms
zhoxing-ms reviewed Sep 4, 2023
View reviewed changes
@Greedygre
Copy link
Contributor Author

Greedygre commented Sep 5, 2023

Hi @zhoxing-ms
Comment addressed, could you please help to review and approve? Thanks.

@zhoxing-ms
Copy link
Contributor

zhoxing-ms commented Sep 5, 2023

vendored_sdks/kubernetesconfiguration --> vendored_sdks/kubernetes_configuration

Suggest making the naming of folder for vendored sdk more readable

@Greedygre
Copy link
Contributor Author

Greedygre commented Sep 5, 2023 •
edited
Loading

vendored_sdks/kubernetesconfiguration --> vendored_sdks/kubernetes_configuration

Suggest making the naming of folder for vendored sdk more readable

Hi, this directory name is consisting with the azure-mgmt-kubernetesconfiguration.

@zhoxing-ms zhoxing-ms merged commit d5d894c into Azure:main Sep 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zhoxing-ms zhoxing-ms zhoxing-ms approved these changes

@Juliehzl Juliehzl Juliehzl approved these changes

@yonzhan yonzhan Awaiting requested review from yonzhan

@wangzelin007 wangzelin007 Awaiting requested review from wangzelin007

@yanzhudd yanzhudd Awaiting requested review from yanzhudd

@jsntcy jsntcy Awaiting requested review from jsntcy

@ruslany ruslany Awaiting requested review from ruslany

@sanchitmehta sanchitmehta Awaiting requested review from sanchitmehta

@ebencarek ebencarek Awaiting requested review from ebencarek

@JennyLawrance JennyLawrance Awaiting requested review from JennyLawrance

@howang-ms howang-ms Awaiting requested review from howang-ms howang-ms is a code owner

@vinisoto vinisoto Awaiting requested review from vinisoto

@chinadragon0515 chinadragon0515 Awaiting requested review from chinadragon0515

@vturecek vturecek Awaiting requested review from vturecek

@torosent torosent Awaiting requested review from torosent

@pagariyaalok pagariyaalok Awaiting requested review from pagariyaalok

@jijohn14 jijohn14 Awaiting requested review from jijohn14

+1 more reviewer

@LaylaLiu-gmail LaylaLiu-gmail LaylaLiu-gmail left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@zhoxing-ms zhoxing-ms

Labels

Auto-Assign Auto assign by bot ContainerApp

Projects

None yet

Milestone

September 2023 (2023-09-26)

Development

Successfully merging this pull request may close these issues.

5 participants

@Greedygre @yonzhan @zhoxing-ms @LaylaLiu-gmail @Juliehzl